Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issue 412 #445

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Fix/issue 412 #445

merged 2 commits into from
Mar 24, 2023

Conversation

mkXultra
Copy link
Contributor

mkXultra added 2 commits March 17, 2023 18:28
@mkXultra
modify: rename variable name and define type
d7cf829
@mkXultra
Merge branch 'newDevelop' of https://github.com/UnUniFi/chain into fi…
b985f75 
…x/issue_412

 Conflicts:
	x/derivatives/keeper/grpc_query.go
	x/derivatives/types/positions.go
@mkXultra mkXultra requested a review from taiki1frsh March 17, 2023 09:43
@mkXultra mkXultra self-assigned this Mar 17, 2023
taiki1frsh
taiki1frsh approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@taiki1frsh taiki1frsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkXultra
Copy link
Contributor Author

copilot:summary

@mkXultra mkXultra merged commit 31dd92e into newDevelop Mar 24, 2023
@mkXultra mkXultra deleted the fix/issue_412 branch March 24, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki1frsh taiki1frsh taiki1frsh approved these changes

Assignees

@mkXultra mkXultra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkXultra @taiki1frsh